diff options
| author |   Yuyang Du <duyuyang@gmail.com> | 2019-05-06 16:19:27 +0800 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2019-06-03 11:55:44 +0200 |
| commit | 31a490e5c54f5499aa744f8524611e2a4b19f8ba (patch) | |
| tree | 53f4bf128cfbfe9da737fae6cab5f5a2587517db /kernel/locking | |
| parent | locking/lockdep: Remove unused argument in validate_chain() and check_deadlock() (diff) | |
| download | linux-dev-31a490e5c54f5499aa744f8524611e2a4b19f8ba.tar.xz linux-dev-31a490e5c54f5499aa744f8524611e2a4b19f8ba.zip | |
locking/lockdep: Update comment
A leftover comment is removed. While at it, add more explanatory
comments. Such a trivial patch!
Signed-off-by: Yuyang Du <duyuyang@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: bvanassche@acm.org
Cc: frederic@kernel.org
Cc: ming.lei@redhat.com
Cc: will.deacon@arm.com
Link: https://lkml.kernel.org/r/20190506081939.74287-12-duyuyang@gmail.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'kernel/locking')
| -rw-r--r-- | kernel/locking/lockdep.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 6cf14c84eb6d..a9799f9ed093 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -2811,10 +2811,16 @@ static int validate_chain(struct task_struct *curr, * - is softirq-safe, if this lock is hardirq-unsafe * * And check whether the new lock's dependency graph - * could lead back to the previous lock. + * could lead back to the previous lock: * - * any of these scenarios could lead to a deadlock. If - * All validations + * - within the current held-lock stack + * - across our accumulated lock dependency records + * + * any of these scenarios could lead to a deadlock. + */ + /* + * The simple case: does the current hold the same lock + * already? */ int ret = check_deadlock(curr, hlock, hlock->read); |