diff options
| author |   Boqun Feng <boqun.feng@gmail.com> | 2021-06-19 01:01:08 +0800 |
|---|---|---|
| committer |   Peter Zijlstra <peterz@infradead.org> | 2021-06-22 16:42:07 +0200 |
| commit | d4c157c7b1a67a0844a904baaca9a840c196c103 (patch) | |
| tree | e716bdd8c65297b0911335f89f765ab96dc2f096 /kernel/locking | |
| parent | locking/lockdep: Fix the dep path printing for backwards BFS (diff) | |
| download | linux-dev-d4c157c7b1a67a0844a904baaca9a840c196c103.tar.xz linux-dev-d4c157c7b1a67a0844a904baaca9a840c196c103.zip | |
locking/lockdep: Remove the unnecessary trace saving
In print_bad_irq_dependency(), save_trace() is called to set the ->trace
for @prev_root as the current call trace, however @prev_root corresponds
to the the held lock, which may not be acquired in current call trace,
therefore it's wrong to use save_trace() to set ->trace of @prev_root.
Moreover, with our adjustment of printing backwards dependency path, the
->trace of @prev_root is unncessary, so remove it.
Reported-by: Johannes Berg <johannes@sipsolutions.net>
Signed-off-by: Boqun Feng <boqun.feng@gmail.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20210618170110.3699115-3-boqun.feng@gmail.com
Diffstat (limited to 'kernel/locking')
| -rw-r--r-- | kernel/locking/lockdep.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/kernel/locking/lockdep.c b/kernel/locking/lockdep.c index 3b32cd9cdfd0..74d084a398be 100644 --- a/kernel/locking/lockdep.c +++ b/kernel/locking/lockdep.c @@ -2550,9 +2550,6 @@ print_bad_irq_dependency(struct task_struct *curr, lockdep_print_held_locks(curr); pr_warn("\nthe dependencies between %s-irq-safe lock and the holding lock:\n", irqclass); - prev_root->trace = save_trace(); - if (!prev_root->trace) - return; print_shortest_lock_dependencies_backwards(backwards_entry, prev_root); pr_warn("\nthe dependencies between the lock to be acquired"); |