diff options
| author |   Andrew Morton <akpm@linux-foundation.org> | 2008-02-08 04:18:43 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.linux-foundation.org> | 2008-02-08 09:22:24 -0800 |
| commit | 92dfc9dc7ba63134f721b6e745dbdcfc13ea341b (patch) | |
| tree | aa959d2d5ba1819651888601e4d917b01ddcc88c /kernel/module.c | |
| parent | modules: include sections.h to avoid defining linker variables explicitly (diff) | |
| download | linux-dev-92dfc9dc7ba63134f721b6e745dbdcfc13ea341b.tar.xz linux-dev-92dfc9dc7ba63134f721b6e745dbdcfc13ea341b.zip | |
fix "modules: make module_address_lookup() safe"
Get the constness right, avoid nasty cast.
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Kyle McMartin <kyle@mcmartin.ca>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'kernel/module.c')
| -rw-r--r-- | kernel/module.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/kernel/module.c b/kernel/module.c index 676c023c831b..4202da97a1da 100644 --- a/kernel/module.c +++ b/kernel/module.c @@ -2253,7 +2253,7 @@ static const char *get_ksymbol(struct module *mod, /* For kallsyms to ask for address resolution. NULL means not found. Careful * not to lock to avoid deadlock on oopses, simply disable preemption. */ -char *module_address_lookup(unsigned long addr, +const char *module_address_lookup(unsigned long addr, unsigned long *size, unsigned long *offset, char **modname, @@ -2278,7 +2278,7 @@ char *module_address_lookup(unsigned long addr, ret = namebuf; } preempt_enable(); - return (char *)ret; + return ret; } int lookup_module_symbol_name(unsigned long addr, char *symname) |