diff options
| author |   Joel Fernandes (Google) <joel@joelfernandes.org> | 2020-08-07 13:07:19 -0400 |
|---|---|---|
| committer |   Paul E. McKenney <paulmck@kernel.org> | 2020-08-24 18:37:55 -0700 |
| commit | f37599e6f06da47e49c3408afe66c5b6e83a90bd (patch) | |
| tree | 17046e0271937e631b728c060b9812fb412a5989 /kernel/rcu | |
| parent | rcu/nocb: Add a warning for non-GP kthread running GP code (diff) | |
| download | linux-dev-f37599e6f06da47e49c3408afe66c5b6e83a90bd.tar.xz linux-dev-f37599e6f06da47e49c3408afe66c5b6e83a90bd.zip | |
rcu: Clarify comments about FQS loop reporting quiescent states
Since at least v4.19, the FQS loop no longer reports quiescent states
for offline CPUs except in emergency situations.
This commit therefore fixes the comment in rcu_gp_init() to match the
current code.
Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Diffstat (limited to 'kernel/rcu')
| -rw-r--r-- | kernel/rcu/tree.c | 11 |
1 files changed, 7 insertions, 4 deletions
diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 52108dd92169..2c7afe491c45 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1706,10 +1706,13 @@ static bool rcu_gp_init(void) raw_spin_unlock_irq_rcu_node(rnp); /* - * Apply per-leaf buffered online and offline operations to the - * rcu_node tree. Note that this new grace period need not wait - * for subsequent online CPUs, and that quiescent-state forcing - * will handle subsequent offline CPUs. + * Apply per-leaf buffered online and offline operations to + * the rcu_node tree. Note that this new grace period need not + * wait for subsequent online CPUs, and that RCU hooks in the CPU + * offlining path, when combined with checks in this function, + * will handle CPUs that are currently going offline or that will + * go offline later. Please also refer to "Hotplug CPU" section + * of RCU's Requirements documentation. */ rcu_state.gp_state = RCU_GP_ONOFF; rcu_for_each_leaf_node(rnp) { |