diff options
| author |   Vincent Guittot <vincent.guittot@linaro.org> | 2021-02-24 14:30:02 +0100 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2021-03-06 12:40:21 +0100 |
| commit | ab2dde5e98db23387147fb4e7a52b6cf8141cdb3 (patch) | |
| tree | d0eeaae4162634781f698c7fc696d73ae52f4cc2 /kernel/sched/fair.c | |
| parent | sched/fair: Remove update of blocked load from newidle_balance (diff) | |
| download | linux-dev-ab2dde5e98db23387147fb4e7a52b6cf8141cdb3.tar.xz linux-dev-ab2dde5e98db23387147fb4e7a52b6cf8141cdb3.zip | |
sched/fair: Remove unused return of _nohz_idle_balance
The return of _nohz_idle_balance() is not used anymore so we can remove
it
Signed-off-by: Vincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Valentin Schneider <valentin.schneider@arm.com>
Link: https://lkml.kernel.org/r/20210224133007.28644-3-vincent.guittot@linaro.org
Diffstat (limited to 'kernel/sched/fair.c')
| -rw-r--r-- | kernel/sched/fair.c | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 806e16fe35ba..6a458e9452ee 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -10354,10 +10354,8 @@ out: * Internal function that runs load balance for all idle cpus. The load balance * can be a simple update of blocked load or a complete load balance with * tasks movement depending of flags. - * The function returns false if the loop has stopped before running - * through all idle CPUs. */ -static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, +static void _nohz_idle_balance(struct rq *this_rq, unsigned int flags, enum cpu_idle_type idle) { /* Earliest time when we have to do rebalance again */ @@ -10367,7 +10365,6 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, int update_next_balance = 0; int this_cpu = this_rq->cpu; int balance_cpu; - int ret = false; struct rq *rq; SCHED_WARN_ON((flags & NOHZ_KICK_MASK) == NOHZ_BALANCE_KICK); @@ -10447,15 +10444,10 @@ static bool _nohz_idle_balance(struct rq *this_rq, unsigned int flags, WRITE_ONCE(nohz.next_blocked, now + msecs_to_jiffies(LOAD_AVG_PERIOD)); - /* The full idle balance loop has been done */ - ret = true; - abort: /* There is still blocked load, enable periodic update */ if (has_blocked_load) WRITE_ONCE(nohz.has_blocked, 1); - - return ret; } /* |