diff options
| author |   Mathieu Desnoyers <mathieu.desnoyers@efficios.com> | 2021-02-17 11:56:51 -0500 |
|---|---|---|
| committer |   Ingo Molnar <mingo@kernel.org> | 2021-03-06 12:40:21 +0100 |
| commit | ce29ddc47b91f97e7f69a0fb7cbb5845f52a9825 (patch) | |
| tree | c78f7da880f9002fe60aa2de83f73976757acd66 /kernel/sched/membarrier.c | |
| parent | sched: Simplify set_affinity_pending refcounts (diff) | |
| download | linux-dev-ce29ddc47b91f97e7f69a0fb7cbb5845f52a9825.tar.xz linux-dev-ce29ddc47b91f97e7f69a0fb7cbb5845f52a9825.zip | |
sched/membarrier: fix missing local execution of ipi_sync_rq_state()
The function sync_runqueues_membarrier_state() should copy the
membarrier state from the @mm received as parameter to each runqueue
currently running tasks using that mm.
However, the use of smp_call_function_many() skips the current runqueue,
which is unintended. Replace by a call to on_each_cpu_mask().
Fixes: 227a4aadc75b ("sched/membarrier: Fix p->mm->membarrier_state racy load")
Reported-by: Nadav Amit <nadav.amit@gmail.com>
Signed-off-by: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Cc: stable@vger.kernel.org # 5.4.x+
Link: https://lore.kernel.org/r/74F1E842-4A84-47BF-B6C2-5407DFDD4A4A@gmail.com
Diffstat (limited to 'kernel/sched/membarrier.c')
| -rw-r--r-- | kernel/sched/membarrier.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/kernel/sched/membarrier.c b/kernel/sched/membarrier.c index acdae625c636..b5add64d9698 100644 --- a/kernel/sched/membarrier.c +++ b/kernel/sched/membarrier.c @@ -471,9 +471,7 @@ static int sync_runqueues_membarrier_state(struct mm_struct *mm) } rcu_read_unlock(); - preempt_disable(); - smp_call_function_many(tmpmask, ipi_sync_rq_state, mm, 1); - preempt_enable(); + on_each_cpu_mask(tmpmask, ipi_sync_rq_state, mm, true); free_cpumask_var(tmpmask); cpus_read_unlock(); |