aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/time/timer.c
diff options
context:
space:
mode:
authorFrederic Weisbecker <frederic@kernel.org>2021-06-03 01:15:59 +0200
committerFrederic Weisbecker <frederic@kernel.org>2021-07-15 01:20:10 +0200
commit1a3402d93c73bf6bb4df6d7c2aac35abfc3c50e2 (patch)
treeff4ae75a802a4ef3b30d296afcc14597e0225b8a /kernel/time/timer.c
parentLinux 5.14-rc1 (diff)
downloadlinux-dev-1a3402d93c73bf6bb4df6d7c2aac35abfc3c50e2.tar.xz
linux-dev-1a3402d93c73bf6bb4df6d7c2aac35abfc3c50e2.zip
posix-cpu-timers: Fix rearm racing against process tick
Since the process wide cputime counter is started locklessly from posix_cpu_timer_rearm(), it can be concurrently stopped by operations on other timers from the same thread group, such as in the following unlucky scenario: CPU 0 CPU 1 ----- ----- timer_settime(TIMER B) posix_cpu_timer_rearm(TIMER A) cpu_clock_sample_group() (pct->timers_active already true) handle_posix_cpu_timers() check_process_timers() stop_process_timers() pct->timers_active = false arm_timer(TIMER A) tick -> run_posix_cpu_timers() // sees !pct->timers_active, ignore // our TIMER A Fix this with simply locking process wide cputime counting start and timer arm in the same block. Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> Signed-off-by: Frederic Weisbecker <frederic@kernel.org> Fixes: 60f2ceaa8111 ("posix-cpu-timers: Remove unnecessary locking around cpu_clock_sample_group") Cc: stable@vger.kernel.org Cc: Oleg Nesterov <oleg@redhat.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Eric W. Biederman <ebiederm@xmission.com>
Diffstat (limited to 'kernel/time/timer.c')
0 files changed, 0 insertions, 0 deletions