diff options
| author |   Viresh Kumar <viresh.kumar@linaro.org> | 2014-06-12 16:24:41 +0530 |
|---|---|---|
| committer |   Frederic Weisbecker <frederic@kernel.org> | 2014-08-22 18:47:35 +0200 |
| commit | 2a16fc93d2c9568e16d45db77c7b5f15e1921cf1 (patch) | |
| tree | 5488a9508a8767e248aab6029f623e7e9dfbb224 /kernel/time | |
| parent | nohz: Fix spurious periodic tick behaviour in low-res dynticks mode (diff) | |
| download | linux-dev-2a16fc93d2c9568e16d45db77c7b5f15e1921cf1.tar.xz linux-dev-2a16fc93d2c9568e16d45db77c7b5f15e1921cf1.zip | |
nohz: Avoid tick's double reprogramming in highres mode
In highres mode, the tick reschedules itself unconditionally to the
next jiffies.
However while this clock reprogramming is relevant when the tick is
in periodic mode, it's not that interesting when we run in dynticks mode
because irq exit is likely going to overwrite the next tick to some
randomly deferred future.
So lets just get rid of this tick self rescheduling in dynticks mode.
This way we can avoid some clockevents double write in favourable
scenarios like when we stop the tick completely in idle while no other
hrtimer is pending.
Suggested-by: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'kernel/time')
| -rw-r--r-- | kernel/time/tick-sched.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/kernel/time/tick-sched.c b/kernel/time/tick-sched.c index 153870a91350..cc0a5b6f741b 100644 --- a/kernel/time/tick-sched.c +++ b/kernel/time/tick-sched.c @@ -1099,6 +1099,10 @@ static enum hrtimer_restart tick_sched_timer(struct hrtimer *timer) if (regs) tick_sched_handle(ts, regs); + /* No need to reprogram if we are in idle or full dynticks mode */ + if (unlikely(ts->tick_stopped)) + return HRTIMER_NORESTART; + hrtimer_forward(timer, now, tick_period); return HRTIMER_RESTART; |