aboutsummaryrefslogtreecommitdiffstats
path: root/kernel/timer.c
diff options
context:
space:
mode:
authorTejun Heo <tj@kernel.org>2012-05-14 15:04:50 -0700
committerTejun Heo <tj@kernel.org>2012-05-14 15:04:50 -0700
commit544ecf310f0e7f51fa057ac2a295fc1b3b35a9d3 (patch)
tree417e606b3a1a7eaa31a3847a5101db37041e0c20 /kernel/timer.c
parentworkqueue: Catch more locking problems with flush_work() (diff)
downloadlinux-dev-544ecf310f0e7f51fa057ac2a295fc1b3b35a9d3.tar.xz
linux-dev-544ecf310f0e7f51fa057ac2a295fc1b3b35a9d3.zip
workqueue: skip nr_running sanity check in worker_enter_idle() if trustee is active
worker_enter_idle() has WARN_ON_ONCE() which triggers if nr_running isn't zero when every worker is idle. This can trigger spuriously while a cpu is going down due to the way trustee sets %WORKER_ROGUE and zaps nr_running. It first sets %WORKER_ROGUE on all workers without updating nr_running, releases gcwq->lock, schedules, regrabs gcwq->lock and then zaps nr_running. If the last running worker enters idle inbetween, it would see stale nr_running which hasn't been zapped yet and trigger the WARN_ON_ONCE(). Fix it by performing the sanity check iff the trustee is idle. Signed-off-by: Tejun Heo <tj@kernel.org> Reported-by: "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> Cc: stable@vger.kernel.org
Diffstat (limited to 'kernel/timer.c')
0 files changed, 0 insertions, 0 deletions