diff options
| author |   Steven Rostedt <srostedt@redhat.com> | 2013-01-22 23:35:11 -0500 |
|---|---|---|
| committer |   Steven Rostedt <rostedt@goodmis.org> | 2013-01-22 23:35:11 -0500 |
| commit | 05cbbf643b8eea1be21082c53cdb856d1dc6d765 (patch) | |
| tree | 74d3484ab036aa7d50473562bb995d6a6ab95b74 /kernel/trace/trace_selftest.c | |
| parent | tracing: Fix race with max_tr and changing tracers (diff) | |
| download | linux-dev-05cbbf643b8eea1be21082c53cdb856d1dc6d765.tar.xz linux-dev-05cbbf643b8eea1be21082c53cdb856d1dc6d765.zip | |
tracing: Fix selftest function recursion accounting
The test that checks function recursion does things differently
if the arch does not support all ftrace features. But that really
doesn't make a difference with how the test runs, and either way
the count variable should be 2 at the end.
Currently the test wrongly fails for archs that don't support all
the ftrace features.
Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Diffstat (limited to 'kernel/trace/trace_selftest.c')
| -rw-r--r-- | kernel/trace/trace_selftest.c | 16 |
1 files changed, 3 insertions, 13 deletions
diff --git a/kernel/trace/trace_selftest.c b/kernel/trace/trace_selftest.c index 6c62d58d8e87..adb008a0136f 100644 --- a/kernel/trace/trace_selftest.c +++ b/kernel/trace/trace_selftest.c @@ -452,7 +452,6 @@ trace_selftest_function_recursion(void) char *func_name; int len; int ret; - int cnt; /* The previous test PASSED */ pr_cont("PASSED\n"); @@ -510,19 +509,10 @@ trace_selftest_function_recursion(void) unregister_ftrace_function(&test_recsafe_probe); - /* - * If arch supports all ftrace features, and no other task - * was on the list, we should be fine. - */ - if (!ftrace_nr_registered_ops() && !FTRACE_FORCE_LIST_FUNC) - cnt = 2; /* Should have recursed */ - else - cnt = 1; - ret = -1; - if (trace_selftest_recursion_cnt != cnt) { - pr_cont("*callback not called expected %d times (%d)* ", - cnt, trace_selftest_recursion_cnt); + if (trace_selftest_recursion_cnt != 2) { + pr_cont("*callback not called expected 2 times (%d)* ", + trace_selftest_recursion_cnt); goto out; } |