diff options
| author |   Li Zefan <lizf@cn.fujitsu.com> | 2009-05-27 11:04:26 +0800 |
|---|---|---|
| committer |   Frederic Weisbecker <fweisbec@gmail.com> | 2009-06-02 01:17:49 +0200 |
| commit | b3dd7ba7d862707800c7ac45068f14ade2b65155 (patch) | |
| tree | 2b39cf635ea0c8acb52bea38edd6a8db843644d4 /kernel/trace/trace_stat.c | |
| parent | tracing/stat: replace linked list by an rbtree for sorting (diff) | |
| download | linux-dev-b3dd7ba7d862707800c7ac45068f14ade2b65155.tar.xz linux-dev-b3dd7ba7d862707800c7ac45068f14ade2b65155.zip | |
tracing/stat: change dummpy_cmp() to return -1
Currently the output of trace_stat/workqueues is totally reversed:
# cat /debug/tracing/trace_stat/workqueues
...
1 17 17 210 37 `-blk_unplug_work+0x0/0x57
1 3779 3779 181 11 |-cfq_kick_queue+0x0/0x2f
1 3796 3796 kblockd/1:120
...
The correct output should be:
1 3796 3796 kblockd/1:120
1 3779 3779 181 11 |-cfq_kick_queue+0x0/0x2f
1 17 17 210 37 `-blk_unplug_work+0x0/0x57
It's caused by "tracing/stat: replace linked list by an rbtree for
sorting"
(53059c9b67a62a3dc8c80204d3da42b9267ea5a0).
dummpy_cmp() should return -1, so rb_node will always be inserted as
right-most node in the rbtree, thus we sort the output in ascending
order.
[ Impact: fix the output of trace_stat/workqueues ]
Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Diffstat (limited to 'kernel/trace/trace_stat.c')
| -rw-r--r-- | kernel/trace/trace_stat.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/trace/trace_stat.c b/kernel/trace/trace_stat.c index 0bd0fc82da5d..5816d1aebcc9 100644 --- a/kernel/trace/trace_stat.c +++ b/kernel/trace/trace_stat.c @@ -127,7 +127,7 @@ insert_stat(struct rb_root *root, struct stat_node *data, cmp_stat_t cmp) */ static int dummy_cmp(void *p1, void *p2) { - return 1; + return -1; } /* |