diff options
| author |   Eric W. Biederman <ebiederm@xmission.com> | 2020-07-13 12:06:48 -0500 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2020-07-21 08:24:52 -0500 |
| commit | be619f7f063a49c656f620a46af4f8ea3e759e91 (patch) | |
| tree | be0f257b8da82e9e2eb9bdaa2574a48221e7b516 /kernel/umh.c | |
| parent | exec: Factor bprm_stack_limits out of prepare_arg_pages (diff) | |
| download | linux-dev-be619f7f063a49c656f620a46af4f8ea3e759e91.tar.xz linux-dev-be619f7f063a49c656f620a46af4f8ea3e759e91.zip | |
exec: Implement kernel_execve
To allow the kernel not to play games with set_fs to call exec
implement kernel_execve. The function kernel_execve takes pointers
into kernel memory and copies the values pointed to onto the new
userspace stack.
The calls with arguments from kernel space of do_execve are replaced
with calls to kernel_execve.
The calls do_execve and do_execveat are made static as there are now
no callers outside of exec.
The comments that mention do_execve are updated to refer to
kernel_execve or execve depending on the circumstances. In addition
to correcting the comments, this makes it easy to grep for do_execve
and verify it is not used.
Inspired-by: https://lkml.kernel.org/r/20200627072704.2447163-1-hch@lst.de
Reviewed-by: Kees Cook <keescook@chromium.org>
Link: https://lkml.kernel.org/r/87wo365ikj.fsf@x220.int.ebiederm.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'kernel/umh.c')
| -rw-r--r-- | kernel/umh.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/umh.c b/kernel/umh.c index 6ca2096298b9..a25433f9cd9a 100644 --- a/kernel/umh.c +++ b/kernel/umh.c @@ -98,9 +98,9 @@ static int call_usermodehelper_exec_async(void *data) commit_creds(new); - retval = do_execve(getname_kernel(sub_info->path), - (const char __user *const __user *)sub_info->argv, - (const char __user *const __user *)sub_info->envp); + retval = kernel_execve(sub_info->path, + (const char *const *)sub_info->argv, + (const char *const *)sub_info->envp); out: sub_info->retval = retval; /* |