diff options
| author |   Sami Tolvanen <samitolvanen@google.com> | 2021-04-08 11:28:30 -0700 |
|---|---|---|
| committer |   Kees Cook <keescook@chromium.org> | 2021-04-08 16:04:21 -0700 |
| commit | 981731129e0fc1d3aa3213195904c9bf45fa9f36 (patch) | |
| tree | 3171968b4ed89ce5fda2e5ad1513fbb4349ec774 /kernel/workqueue.c | |
| parent | module: ensure __cfi_check alignment (diff) | |
| download | linux-dev-981731129e0fc1d3aa3213195904c9bf45fa9f36.tar.xz linux-dev-981731129e0fc1d3aa3213195904c9bf45fa9f36.zip | |
workqueue: use WARN_ON_FUNCTION_MISMATCH
With CONFIG_CFI_CLANG, a callback function passed to
__queue_delayed_work from a module points to a jump table entry
defined in the module instead of the one used in the core kernel,
which breaks function address equality in this check:
WARN_ON_ONCE(timer->function != delayed_work_timer_fn);
Use WARN_ON_FUNCTION_MISMATCH() instead to disable the warning
when CFI and modules are both enabled.
Signed-off-by: Sami Tolvanen <samitolvanen@google.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20210408182843.1754385-6-samitolvanen@google.com
Diffstat (limited to 'kernel/workqueue.c')
| -rw-r--r-- | kernel/workqueue.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/kernel/workqueue.c b/kernel/workqueue.c index 0d150da252e8..03fe07d2f39f 100644 --- a/kernel/workqueue.c +++ b/kernel/workqueue.c @@ -1630,7 +1630,7 @@ static void __queue_delayed_work(int cpu, struct workqueue_struct *wq, struct work_struct *work = &dwork->work; WARN_ON_ONCE(!wq); - WARN_ON_ONCE(timer->function != delayed_work_timer_fn); + WARN_ON_FUNCTION_MISMATCH(timer->function, delayed_work_timer_fn); WARN_ON_ONCE(timer_pending(timer)); WARN_ON_ONCE(!list_empty(&work->entry)); |