aboutsummaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorNathan Chancellor <natechancellor@gmail.com>2019-10-03 10:11:21 -0700
committerChristian Brauner <christian.brauner@ubuntu.com>2019-10-03 21:13:27 +0200
commit341115822f8832f0c2d8af2f7e151c4c9a77bcd1 (patch)
treebb30a7babcf846bf5e7c03b1f5c7ac9a85743262 /kernel
parentperf_event_open: switch to copy_struct_from_user() (diff)
downloadlinux-dev-341115822f8832f0c2d8af2f7e151c4c9a77bcd1.tar.xz
linux-dev-341115822f8832f0c2d8af2f7e151c4c9a77bcd1.zip
usercopy: Add parentheses around assignment in test_copy_struct_from_user
Clang warns: lib/test_user_copy.c:96:10: warning: using the result of an assignment as a condition without parentheses [-Wparentheses] if (ret |= test(umem_src == NULL, "kmalloc failed")) ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ lib/test_user_copy.c:96:10: note: place parentheses around the assignment to silence this warning if (ret |= test(umem_src == NULL, "kmalloc failed")) ^ ( ) lib/test_user_copy.c:96:10: note: use '!=' to turn this compound assignment into an inequality comparison if (ret |= test(umem_src == NULL, "kmalloc failed")) ^~ != Add the parentheses as it suggests because this is intentional. Fixes: f5a1a536fa14 ("lib: introduce copy_struct_from_user() helper") Link: https://github.com/ClangBuiltLinux/linux/issues/731 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Acked-by: Aleksa Sarai <cyphar@cyphar.com> Acked-by: Christian Brauner <christian.brauner@ubuntu.com> Link: https://lore.kernel.org/r/20191003171121.2723619-1-natechancellor@gmail.com Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
Diffstat (limited to 'kernel')
0 files changed, 0 insertions, 0 deletions