diff options
| author |   Yonghong Song <yhs@fb.com> | 2017-09-18 16:38:36 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2017-09-20 14:10:29 -0700 |
| commit | ec9dd352d591f0c90402ec67a317c1ed4fb2e638 (patch) | |
| tree | 6c44d1a7f5fd0fa102dac35a26586a7c4b22c8dd /kernel | |
| parent | packet: hold bind lock when rebinding to fanout hook (diff) | |
| download | linux-dev-ec9dd352d591f0c90402ec67a317c1ed4fb2e638.tar.xz linux-dev-ec9dd352d591f0c90402ec67a317c1ed4fb2e638.zip | |
bpf: one perf event close won't free bpf program attached by another perf event
This patch fixes a bug exhibited by the following scenario:
1. fd1 = perf_event_open with attr.config = ID1
2. attach bpf program prog1 to fd1
3. fd2 = perf_event_open with attr.config = ID1
<this will be successful>
4. user program closes fd2 and prog1 is detached from the tracepoint.
5. user program with fd1 does not work properly as tracepoint
no output any more.
The issue happens at step 4. Multiple perf_event_open can be called
successfully, but only one bpf prog pointer in the tp_event. In the
current logic, any fd release for the same tp_event will free
the tp_event->prog.
The fix is to free tp_event->prog only when the closing fd
corresponds to the one which registered the program.
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'kernel')
| -rw-r--r-- | kernel/events/core.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/kernel/events/core.c b/kernel/events/core.c index 3e691b75b2db..6bc21e202ae4 100644 --- a/kernel/events/core.c +++ b/kernel/events/core.c @@ -8171,6 +8171,7 @@ static int perf_event_set_bpf_prog(struct perf_event *event, u32 prog_fd) } } event->tp_event->prog = prog; + event->tp_event->bpf_prog_owner = event; return 0; } @@ -8185,7 +8186,7 @@ static void perf_event_free_bpf_prog(struct perf_event *event) return; prog = event->tp_event->prog; - if (prog) { + if (prog && event->tp_event->bpf_prog_owner == event) { event->tp_event->prog = NULL; bpf_prog_put(prog); } |