diff options
| author |   Eric Biggers <ebiggers@google.com> | 2022-07-25 11:36:35 -0700 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2022-08-19 18:39:34 +0800 |
| commit | 6e78ad0bb45dd20b3c1a56c72a32e1d82f98b422 (patch) | |
| tree | 65ac4a9b20b465269f3bfc453cc0c773525faa5b /lib/crypto/Makefile | |
| parent | crypto: lib - create utils module and move __crypto_memneq into it (diff) | |
| download | linux-dev-6e78ad0bb45dd20b3c1a56c72a32e1d82f98b422.tar.xz linux-dev-6e78ad0bb45dd20b3c1a56c72a32e1d82f98b422.zip | |
crypto: lib - move __crypto_xor into utils
CRYPTO_LIB_CHACHA depends on CRYPTO for __crypto_xor, defined in
crypto/algapi.c. This is a layering violation because the dependencies
should only go in the other direction (crypto/ => lib/crypto/). Also
the correct dependency would be CRYPTO_ALGAPI, not CRYPTO. Fix this by
moving __crypto_xor into the utils module in lib/crypto/.
Note that CRYPTO_LIB_CHACHA_GENERIC selected XOR_BLOCKS, which is
unrelated and unnecessary. It was perhaps thought that XOR_BLOCKS was
needed for __crypto_xor, but that's not the case.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'lib/crypto/Makefile')
| -rw-r--r-- | lib/crypto/Makefile | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/crypto/Makefile b/lib/crypto/Makefile index b956b3bae26a..c852f067ab06 100644 --- a/lib/crypto/Makefile +++ b/lib/crypto/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_CRYPTO_LIB_UTILS) += libcryptoutils.o -libcryptoutils-y := memneq.o +libcryptoutils-y := memneq.o utils.o # chacha is used by the /dev/random driver which is always builtin obj-y += chacha.o |