diff options
| author |   Niklas Schnelle <schnelle@linux.ibm.com> | 2021-03-24 11:21:21 +0100 |
|---|---|---|
| committer |   Heiko Carstens <hca@linux.ibm.com> | 2021-03-28 20:23:54 +0200 |
| commit | 652d40b2f8bec14957295f999e3d329c3b53390f (patch) | |
| tree | aa52eaa90ff9467f375b61934a7c16aa81d8d16f /lib/errseq.c | |
| parent | s390/spinlock: remove align attribute from arch_spinlock_t (diff) | |
| download | linux-dev-652d40b2f8bec14957295f999e3d329c3b53390f.tar.xz linux-dev-652d40b2f8bec14957295f999e3d329c3b53390f.zip | |
s390/pci: fix DMA cleanup on hard deconfigure
In commit dee60c0dbc83 ("s390/pci: add zpci_event_hard_deconfigured()")
we added a zdev_enabled() check to what was previously an uncoditional
call to zpci_disable_device(). There are two problems with that. Firstly
zpci_had_deconfigured() is only called on event 0x0304 for which the
device is always already disabled by the platform so it is always false.
Secondly zpci_disable_device() not only disables the device but also
calls zpci_dma_exit_device() which is thus not called and we leak the
DMA tables.
Fix this by calling zpci_disable_device() unconditionally to perform
Linux side cleanup including the freeing of DMA tables.
Fixes: dee60c0dbc83 ("s390/pci: add zpci_event_hard_deconfigured()")
Reviewed-by: Matthew Rosato <mjrosato@linux.ibm.com>
Acked-by: Pierre Morel <pmorel@linux.ibm.com>
Signed-off-by: Niklas Schnelle <schnelle@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
Diffstat (limited to 'lib/errseq.c')
0 files changed, 0 insertions, 0 deletions