diff options
| author |   Emil Goode <emilgoode@gmail.com> | 2012-06-26 00:37:32 +0200 |
|---|---|---|
| committer |   Florian Tobias Schandinat <FlorianSchandinat@gmx.de> | 2012-07-08 14:03:17 +0000 |
| commit | 42eb317f7d089f878a06aa358d1f168eac3e5afd (patch) | |
| tree | d6f6de712d85af9a2c432ab8bd5721d9f5b72de9 /lib/mpi/mpi-bit.c | |
| parent | video: w100fb: Reduce sleep mode battery discharge (diff) | |
| download | linux-dev-42eb317f7d089f878a06aa358d1f168eac3e5afd.tar.xz linux-dev-42eb317f7d089f878a06aa358d1f168eac3e5afd.zip | |
grvga: Fix error handling issues
This patch fixes two problems with the error handling in the
grvga_probe function and simplifies it making the code
easier to read.
- If the call to grvga_parse_custom on line 370 fails we use
the wrong label so that release_mem_region will be called
without a call to request_mem_region being made.
- If the call to ioremap on line 436 fails we should not try
to call iounmap in the error handling code.
This patch introduces the following changes:
- Converts request_mem_region into its devm_ equivalent
which simplifies the otherwise messy clean up code.
- Changes the labels for correct error handling and their
names to make the code easier to read.
Signed-off-by: Emil Goode <emilgoode@gmail.com>
Signed-off-by: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Diffstat (limited to 'lib/mpi/mpi-bit.c')
0 files changed, 0 insertions, 0 deletions