diff options
| author |   Roland Dreier <roland@purestorage.com> | 2012-06-04 23:24:51 -0700 |
|---|---|---|
| committer |   Nicholas Bellinger <nab@linux-iscsi.org> | 2012-06-12 20:12:25 -0700 |
| commit | 59e4f541baf728dbb426949bfa9f6862387ffd0e (patch) | |
| tree | 2ae398d642adc5437e01daa0751875ca7997b58e /lib/mpi/mpiutil.c | |
| parent | tcm_qla2xxx: Clear session s_id + loop_id earlier during shutdown (diff) | |
| download | linux-dev-59e4f541baf728dbb426949bfa9f6862387ffd0e.tar.xz linux-dev-59e4f541baf728dbb426949bfa9f6862387ffd0e.zip | |
target: Return error to initiator if SET TARGET PORT GROUPS emulation fails
The error paths in target_emulate_set_target_port_groups() are all
essentially "rc = -EINVAL; goto out;" but the code at "out:" ignores
rc and always returns success. This means that even if eg explicit
ALUA is turned off, the initiator will always see a good SCSI status
for SET TARGET PORT GROUPS.
Fix this by returning rc as is intended. It appears this bug was
added by the following patch:
commit 05d1c7c0d0db4cc25548d9aadebb416888a82327
Author: Andy Grover <agrover@redhat.com>
Date: Wed Jul 20 19:13:28 2011 +0000
target: Make all control CDBs scatter-gather
Signed-off-by: Roland Dreier <roland@purestorage.com>
Cc: Andy Grover <agrover@redhat.com>
Cc: <stable@vger.kernel.org>
Signed-off-by: Nicholas Bellinger <nab@linux-iscsi.org>
Diffstat (limited to 'lib/mpi/mpiutil.c')
0 files changed, 0 insertions, 0 deletions