diff options
| author |   Herbert Xu <herbert@gondor.apana.org.au> | 2019-03-21 09:39:52 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-03-21 13:57:28 -0700 |
| commit | 408f13ef358aa5ad56dc6230c2c7deb92cf462b1 (patch) | |
| tree | fd643bfe2c653f0b674c4c91eeea0d120bf52018 /lib | |
| parent | net-sysfs: Fix memory leak in netdev_register_kobject (diff) | |
| download | linux-dev-408f13ef358aa5ad56dc6230c2c7deb92cf462b1.tar.xz linux-dev-408f13ef358aa5ad56dc6230c2c7deb92cf462b1.zip | |
rhashtable: Still do rehash when we get EEXIST
As it stands if a shrink is delayed because of an outstanding
rehash, we will go into a rescheduling loop without ever doing
the rehash.
This patch fixes this by still carrying out the rehash and then
rescheduling so that we can shrink after the completion of the
rehash should it still be necessary.
The return value of EEXIST captures this case and other cases
(e.g., another thread expanded/rehashed the table at the same
time) where we should still proceed with the rehash.
Fixes: da20420f83ea ("rhashtable: Add nested tables")
Reported-by: Josh Elsasser <jelsasser@appneta.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Tested-by: Josh Elsasser <jelsasser@appneta.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/rhashtable.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/lib/rhashtable.c b/lib/rhashtable.c index 0a105d4af166..97f59abc3e92 100644 --- a/lib/rhashtable.c +++ b/lib/rhashtable.c @@ -416,8 +416,12 @@ static void rht_deferred_worker(struct work_struct *work) else if (tbl->nest) err = rhashtable_rehash_alloc(ht, tbl, tbl->size); - if (!err) - err = rhashtable_rehash_table(ht); + if (!err || err == -EEXIST) { + int nerr; + + nerr = rhashtable_rehash_table(ht); + err = err ?: nerr; + } mutex_unlock(&ht->mutex); |