diff options
| author |   Nick Piggin <npiggin@suse.de> | 2007-02-12 00:51:59 -0800 |
|---|---|---|
| committer |   Linus Torvalds <torvalds@woody.linux-foundation.org> | 2007-02-12 09:48:28 -0800 |
| commit | f9e4acf3befd3b2903e01b3ef1bd344f03299826 (patch) | |
| tree | 26eb1f9e71adfd4bd5678861c8f13fd655adfa60 /lib | |
| parent | [PATCH] remove sb->s_files and file_list_lock usage in dquot.c (diff) | |
| download | linux-dev-f9e4acf3befd3b2903e01b3ef1bd344f03299826.tar.xz linux-dev-f9e4acf3befd3b2903e01b3ef1bd344f03299826.zip | |
[PATCH] inotify: read return val fix
Fix for inotify read bug (bugzilla.kernel.org #6999)
Problem Description:
When reading from an inotify device with an insufficient sized buffer, read(2)
will return 0 with no errno set. This is because of an logically incorrect
action from the user program thus should return an more logical value. My
suggestion is return -EINVAL as for bind(2).
This patch is based on the proposal from Ryan <wolf0403@hotmail.com>, and
feedback from John McCutchan <john@johnmccutchan.com>.
Return -EINVAL if we have not passed in enough buffer space to read a single
inotify event, rather than 0 which indicates that there is nothing to read.
Signed-off-by: Nick Piggin <npiggin@suse.de>
Acked-by: "John McCutchan" <john@johnmccutchan.com>
Cc: Ryan <wolf0403@hotmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'lib')
0 files changed, 0 insertions, 0 deletions