diff options
| author |   Matthias Goergens <matthias.goergens@gmail.com> | 2022-09-05 11:19:04 +0800 |
|---|---|---|
| committer |   Andrew Morton <akpm@linux-foundation.org> | 2022-10-03 14:02:55 -0700 |
| commit | 710bb68c2e3a24512e2d2bae470960d7488e97b1 (patch) | |
| tree | 7a922e8d43a037d5feeebc671212a4285c72c7bb /mm/filemap.c | |
| parent | mm/damon/sysfs: simplify the judgement whether kdamonds are busy (diff) | |
| download | linux-dev-710bb68c2e3a24512e2d2bae470960d7488e97b1.tar.xz linux-dev-710bb68c2e3a24512e2d2bae470960d7488e97b1.zip | |
hugetlb_encode.h: fix undefined behaviour (34 << 26)
Left-shifting past the size of your datatype is undefined behaviour in C.
The literal 34 gets the type `int`, and that one is not big enough to be
left shifted by 26 bits.
An `unsigned` is long enough (on any machine that has at least 32 bits for
their ints.)
For uniformity, we mark all the literals as unsigned. But it's only
really needed for HUGETLB_FLAG_ENCODE_16GB.
Thanks to Randy Dunlap for an initial review and suggestion.
Link: https://lkml.kernel.org/r/20220905031904.150925-1-matthias.goergens@gmail.com
Signed-off-by: Matthias Goergens <matthias.goergens@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Mike Kravetz <mike.kravetz@oracle.com>
Cc: Muchun Song <songmuchun@bytedance.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Diffstat (limited to 'mm/filemap.c')
0 files changed, 0 insertions, 0 deletions