diff options
| author |   Joonsoo Kim <js1304@gmail.com> | 2012-06-23 03:22:38 +0900 |
|---|---|---|
| committer |   Pekka Enberg <penberg@kernel.org> | 2012-08-16 10:06:42 +0300 |
| commit | e24fc410f58cc7851188a6e996dc6ce5c4259eb4 (patch) | |
| tree | b97cc0b129c34868d1f2a71093e1d889d65b13ec /mm/slub.c | |
| parent | slub: Take node lock during object free checks (diff) | |
| download | linux-dev-e24fc410f58cc7851188a6e996dc6ce5c4259eb4.tar.xz linux-dev-e24fc410f58cc7851188a6e996dc6ce5c4259eb4.zip | |
slub: reduce failure of this_cpu_cmpxchg in put_cpu_partial() after unfreezing
In current implementation, after unfreezing, we doesn't touch oldpage,
so it remain 'NOT NULL'. When we call this_cpu_cmpxchg()
with this old oldpage, this_cpu_cmpxchg() is mostly be failed.
We can change value of oldpage to NULL after unfreezing,
because unfreeze_partial() ensure that all the cpu partial slabs is removed
from cpu partial list. In this time, we could expect that
this_cpu_cmpxchg is mostly succeed.
Acked-by: Christoph Lameter <cl@linux.com>
Signed-off-by: Joonsoo Kim <js1304@gmail.com>
Signed-off-by: Pekka Enberg <penberg@kernel.org>
Diffstat (limited to 'mm/slub.c')
| -rw-r--r-- | mm/slub.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/mm/slub.c b/mm/slub.c index e131084e87a3..c67bd0a4a952 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -1962,6 +1962,7 @@ int put_cpu_partial(struct kmem_cache *s, struct page *page, int drain) local_irq_save(flags); unfreeze_partials(s); local_irq_restore(flags); + oldpage = NULL; pobjects = 0; pages = 0; stat(s, CPU_PARTIAL_DRAIN); |