diff options
| author |   Laura Abbott <labbott@redhat.com> | 2018-05-23 11:43:46 -0700 |
|---|---|---|
| committer |   Will Deacon <will.deacon@arm.com> | 2018-05-24 11:19:31 +0100 |
| commit | 82034c23fcbc2389c73d97737f61fa2dd6526413 (patch) | |
| tree | d297bd7683ea4fd6d5e2415f525754628d697c43 /mm/swapfile.c | |
| parent | arm64: fault: Don't leak data in ESR context for user fault on kernel VA (diff) | |
| download | linux-dev-82034c23fcbc2389c73d97737f61fa2dd6526413.tar.xz linux-dev-82034c23fcbc2389c73d97737f61fa2dd6526413.zip | |
arm64: Make sure permission updates happen for pmd/pud
Commit 15122ee2c515 ("arm64: Enforce BBM for huge IO/VMAP mappings")
disallowed block mappings for ioremap since that code does not honor
break-before-make. The same APIs are also used for permission updating
though and the extra checks prevent the permission updates from happening,
even though this should be permitted. This results in read-only permissions
not being fully applied. Visibly, this can occasionaly be seen as a failure
on the built in rodata test when the test data ends up in a section or
as an odd RW gap on the page table dump. Fix this by using
pgattr_change_is_safe instead of p*d_present for determining if the
change is permitted.
Reviewed-by: Kees Cook <keescook@chromium.org>
Tested-by: Peter Robinson <pbrobinson@gmail.com>
Reported-by: Peter Robinson <pbrobinson@gmail.com>
Fixes: 15122ee2c515 ("arm64: Enforce BBM for huge IO/VMAP mappings")
Signed-off-by: Laura Abbott <labbott@redhat.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Diffstat (limited to 'mm/swapfile.c')
0 files changed, 0 insertions, 0 deletions