aboutsummaryrefslogtreecommitdiffstats
path: root/mm
diff options
context:
space:
mode:
authorMingming Cao <cmm@us.ibm.com>2006-12-06 20:38:19 -0800
committerLinus Torvalds <torvalds@woody.osdl.org>2006-12-07 08:39:39 -0800
commit1df1e63b9e9340015c01b85817568fb9afde10bc (patch)
tree10961392c3915cfe1b8317206b3993ed0e4596a6 /mm
parent[PATCH] ext3: fix reservation extension (diff)
downloadlinux-dev-1df1e63b9e9340015c01b85817568fb9afde10bc.tar.xz
linux-dev-1df1e63b9e9340015c01b85817568fb9afde10bc.zip
[PATCH] ext4: fix reservation extension
Hugh Dickins wrote: > Not found anything relevant, but I keep noticing these lines > in ext2_try_to_allocate_with_rsv(), ext3 and ext4 similar: > > } else if (grp_goal > 0 && > (my_rsv->rsv_end - grp_goal + 1) < *count) > try_to_extend_reservation(my_rsv, sb, > *count-my_rsv->rsv_end + grp_goal - 1); > > They're wrong, a no-op in most groups, aren't they? rsv_end is an > absolute block number, whereas grp_goal is group-relative, so the > calculation ought to bring in group_first_block? Or I'm confused. > Signed-off-by: Mingming Cao <cmm@us.ibm.com> Cc: "linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org> Cc: Hugh Dickins <hugh@veritas.com> Signed-off-by: Andrew Morton <akpm@osdl.org> Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Diffstat (limited to 'mm')
0 files changed, 0 insertions, 0 deletions