diff options
| author |   Oliver Neukum <oneukum@suse.de> | 2014-03-26 14:32:51 +0100 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2014-03-27 14:59:10 -0400 |
| commit | 14a0d635d18d0fb552dcc979d6d25106e6541f2e (patch) | |
| tree | 2fa1bce86903a0f841ab662eb85de4445bbfe398 /net/8021q/vlan_dev.c | |
| parent | virtio-net: correct error handling of virtqueue_kick() (diff) | |
| download | linux-dev-14a0d635d18d0fb552dcc979d6d25106e6541f2e.tar.xz linux-dev-14a0d635d18d0fb552dcc979d6d25106e6541f2e.zip | |
usbnet: include wait queue head in device structure
This fixes a race which happens by freeing an object on the stack.
Quoting Julius:
> The issue is
> that it calls usbnet_terminate_urbs() before that, which temporarily
> installs a waitqueue in dev->wait in order to be able to wait on the
> tasklet to run and finish up some queues. The waiting itself looks
> okay, but the access to 'dev->wait' is totally unprotected and can
> race arbitrarily. I think in this case usbnet_bh() managed to succeed
> it's dev->wait check just before usbnet_terminate_urbs() sets it back
> to NULL. The latter then finishes and the waitqueue_t structure on its
> stack gets overwritten by other functions halfway through the
> wake_up() call in usbnet_bh().
The fix is to just not allocate the data structure on the stack.
As dev->wait is abused as a flag it also takes a runtime PM change
to fix this bug.
Signed-off-by: Oliver Neukum <oneukum@suse.de>
Reported-by: Grant Grundler <grundler@google.com>
Tested-by: Grant Grundler <grundler@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q/vlan_dev.c')
0 files changed, 0 insertions, 0 deletions