diff options
| author |   Jakub Kicinski <kuba@kernel.org> | 2020-12-30 19:40:27 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-01-05 16:25:31 -0800 |
| commit | 55b7ab1178cbf41f979ff83236d3321ad35ed2ad (patch) | |
| tree | 416fc729fda3813f01f22c481acddb981df1b015 /net/8021q | |
| parent | net: suggest L2 discards be counted towards rx_dropped (diff) | |
| download | linux-dev-55b7ab1178cbf41f979ff83236d3321ad35ed2ad.tar.xz linux-dev-55b7ab1178cbf41f979ff83236d3321ad35ed2ad.zip | |
net: vlan: avoid leaks on register_vlan_dev() failures
VLAN checks for NETREG_UNINITIALIZED to distinguish between
registration failure and unregistration in progress.
Since commit cb626bf566eb ("net-sysfs: Fix reference count leak")
registration failure may, however, result in NETREG_UNREGISTERED
as well as NETREG_UNINITIALIZED.
This fix is similer to cebb69754f37 ("rtnetlink: Fix
memory(net_device) leak when ->newlink fails")
Fixes: cb626bf566eb ("net-sysfs: Fix reference count leak")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/8021q')
| -rw-r--r-- | net/8021q/vlan.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/8021q/vlan.c b/net/8021q/vlan.c index f292e0267bb9..15bbfaf943fd 100644 --- a/net/8021q/vlan.c +++ b/net/8021q/vlan.c @@ -284,7 +284,8 @@ static int register_vlan_device(struct net_device *real_dev, u16 vlan_id) return 0; out_free_newdev: - if (new_dev->reg_state == NETREG_UNINITIALIZED) + if (new_dev->reg_state == NETREG_UNINITIALIZED || + new_dev->reg_state == NETREG_UNREGISTERED) free_netdev(new_dev); return err; } |