diff options
| author |   Tuomas Tynkkynen <tuomas@tuxera.com> | 2017-09-06 17:59:08 +0300 |
|---|---|---|
| committer |   Al Viro <viro@zeniv.linux.org.uk> | 2017-10-23 23:10:01 -0400 |
| commit | 9523feac272ccad2ad8186ba4fcc89103754de52 (patch) | |
| tree | b97fef39565c4e8dd15c564cff166753eb2a19df /net/9p/client.c | |
| parent | fs/9p: Compare qid.path in v9fs_test_inode (diff) | |
| download | linux-dev-9523feac272ccad2ad8186ba4fcc89103754de52.tar.xz linux-dev-9523feac272ccad2ad8186ba4fcc89103754de52.zip | |
net/9p: Switch to wait_event_killable()
Because userspace gets Very Unhappy when calls like stat() and execve()
return -EINTR on 9p filesystem mounts. For instance, when bash is
looking in PATH for things to execute and some SIGCHLD interrupts
stat(), bash can throw a spurious 'command not found' since it doesn't
retry the stat().
In practice, hitting the problem is rare and needs a really
slow/bogged down 9p server.
Cc: stable@vger.kernel.org
Signed-off-by: Tuomas Tynkkynen <tuomas@tuxera.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Diffstat (limited to 'net/9p/client.c')
| -rw-r--r-- | net/9p/client.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/net/9p/client.c b/net/9p/client.c index 4674235b0d9b..1beb131dd3e1 100644 --- a/net/9p/client.c +++ b/net/9p/client.c @@ -773,8 +773,7 @@ p9_client_rpc(struct p9_client *c, int8_t type, const char *fmt, ...) } again: /* Wait for the response */ - err = wait_event_interruptible(*req->wq, - req->status >= REQ_STATUS_RCVD); + err = wait_event_killable(*req->wq, req->status >= REQ_STATUS_RCVD); /* * Make sure our req is coherent with regard to updates in other |