aboutsummaryrefslogtreecommitdiffstats
path: root/net/9p/trans_common.h
diff options
context:
space:
mode:
authorpiaojun <piaojun@huawei.com>2018-07-13 16:59:06 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2018-07-14 11:11:09 -0700
commitc290fba8c4ce6530cd941ea14db5a4ac2f77183f (patch)
tree6ae7eef41d9099e8c1d3fd99cb24076f9b672ba8 /net/9p/trans_common.h
parentmm: allow arch to supply p??_free_tlb functions (diff)
downloadlinux-dev-c290fba8c4ce6530cd941ea14db5a4ac2f77183f.tar.xz
linux-dev-c290fba8c4ce6530cd941ea14db5a4ac2f77183f.zip
net/9p/client.c: put refcount of trans_mod in error case in parse_opts()
In my testing, the second mount will fail after umounting successfully. The reason is that we put refcount of trans_mod in the correct case rather than the error case in parse_opts() at last. That will cause the refcount decrease to -1, and when we try to get trans_mod again in try_module_get(), we could only increase refcount to 0 which will cause failure as follows: parse_opts v9fs_get_trans_by_name try_module_get : return NULL to caller which cause error So we should put refcount of trans_mod in error case. Link: http://lkml.kernel.org/r/5B3F39A0.2030509@huawei.com Fixes: 9421c3e64137ec ("net/9p/client.c: fix potential refcnt problem of trans module") Signed-off-by: Jun Piao <piaojun@huawei.com> Reviewed-by: Yiwen Jiang <jiangyiwen@huawei.com> Reviewed-by: Greg Kurz <groug@kaod.org> Reviewed-by: Dominique Martinet <dominique.martinet@cea.fr> Tested-by: Dominique Martinet <dominique.martinet@cea.fr> Cc: Eric Van Hensbergen <ericvh@gmail.com> Cc: Ron Minnich <rminnich@sandia.gov> Cc: Latchesar Ionkov <lucho@ionkov.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'net/9p/trans_common.h')
0 files changed, 0 insertions, 0 deletions