diff options
author | Florian Westphal <fw@strlen.de> | 2019-04-17 02:17:23 +0200 |
---|---|---|
committer | Pablo Neira Ayuso <pablo@netfilter.org> | 2019-04-22 10:34:30 +0200 |
commit | 916f6efae62305796e012e7c3a7884a267cbacbf (patch) | |
tree | 59c30037beaae0f4685e6ac4117764f67169bb29 /net/Kconfig | |
parent | netfilter: ebtables: CONFIG_COMPAT: drop a bogus WARN_ON (diff) | |
download | linux-dev-916f6efae62305796e012e7c3a7884a267cbacbf.tar.xz linux-dev-916f6efae62305796e012e7c3a7884a267cbacbf.zip |
netfilter: never get/set skb->tstamp
setting net.netfilter.nf_conntrack_timestamp=1 breaks xmit with fq
scheduler. skb->tstamp might be "refreshed" using ktime_get_real(),
but fq expects CLOCK_MONOTONIC.
This patch removes all places in netfilter that check/set skb->tstamp:
1. To fix the bogus "start" time seen with conntrack timestamping for
outgoing packets, never use skb->tstamp and always use current time.
2. In nfqueue and nflog, only use skb->tstamp for incoming packets,
as determined by current hook (prerouting, input, forward).
3. xt_time has to use system clock as well rather than skb->tstamp.
We could still use skb->tstamp for prerouting/input/foward, but
I see no advantage to make this conditional.
Fixes: fb420d5d91c1 ("tcp/fq: move back to CLOCK_MONOTONIC")
Cc: Eric Dumazet <edumazet@google.com>
Reported-by: Michal Soltys <soltys@ziu.info>
Signed-off-by: Florian Westphal <fw@strlen.de>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'net/Kconfig')
0 files changed, 0 insertions, 0 deletions