diff options
| author |   Herbert Xu <herbert@gondor.apana.org.au> | 2015-07-13 16:04:13 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-07-15 15:59:58 -0700 |
| commit | 738ac1ebb96d02e0d23bc320302a6ea94c612dec (patch) | |
| tree | b2c9c3f8bdf874f4500c1419bfc0eba31b21efb8 /net/ax25 | |
| parent | rtnetlink: reject non-IFLA_VF_PORT attributes inside IFLA_VF_PORTS (diff) | |
| download | linux-dev-738ac1ebb96d02e0d23bc320302a6ea94c612dec.tar.xz linux-dev-738ac1ebb96d02e0d23bc320302a6ea94c612dec.zip | |
net: Clone skb before setting peeked flag
Shared skbs must not be modified and this is crucial for broadcast
and/or multicast paths where we use it as an optimisation to avoid
unnecessary cloning.
The function skb_recv_datagram breaks this rule by setting peeked
without cloning the skb first. This causes funky races which leads
to double-free.
This patch fixes this by cloning the skb and replacing the skb
in the list when setting skb->peeked.
Fixes: a59322be07c9 ("[UDP]: Only increment counter on first peek/recv")
Reported-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ax25')
0 files changed, 0 insertions, 0 deletions