aboutsummaryrefslogtreecommitdiffstats
path: root/net/batman-adv/soft-interface.h
diff options
context:
space:
mode:
authorSven Eckelmann <sven@narfation.org>2016-02-22 21:02:39 +0100
committerAntonio Quartulli <a@unstable.cc>2016-05-10 18:28:54 +0800
commit4b426b108ac82b27f5af40df7da05a2501fd2aca (patch)
treec3dc63c67671262f1abb68fbb4dccc7adacdb3f9 /net/batman-adv/soft-interface.h
parentbatman-adv: Use kref_get for _batadv_update_route (diff)
downloadlinux-dev-4b426b108ac82b27f5af40df7da05a2501fd2aca.tar.xz
linux-dev-4b426b108ac82b27f5af40df7da05a2501fd2aca.zip
batman-adv: Use bool as return type for boolean functions
It is easier to understand that the returned value of a specific function doesn't have to be 0 when the functions was successful when the actual return type is bool. This is especially true when all surrounding functions with return type int use negative values to return the error code. Reported-by: Nicholas Krause <xerofoify@gmail.com> Signed-off-by: Sven Eckelmann <sven@narfation.org> Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch> Signed-off-by: Antonio Quartulli <a@unstable.cc>
Diffstat (limited to 'net/batman-adv/soft-interface.h')
-rw-r--r--net/batman-adv/soft-interface.h3
1 files changed, 2 insertions, 1 deletions
diff --git a/net/batman-adv/soft-interface.h b/net/batman-adv/soft-interface.h
index b0966342a986..ec303ddbf647 100644
--- a/net/batman-adv/soft-interface.h
+++ b/net/batman-adv/soft-interface.h
@@ -20,6 +20,7 @@
#include "main.h"
+#include <linux/types.h>
#include <net/rtnetlink.h>
struct net_device;
@@ -32,7 +33,7 @@ void batadv_interface_rx(struct net_device *soft_iface,
struct batadv_orig_node *orig_node);
struct net_device *batadv_softif_create(struct net *net, const char *name);
void batadv_softif_destroy_sysfs(struct net_device *soft_iface);
-int batadv_softif_is_valid(const struct net_device *net_dev);
+bool batadv_softif_is_valid(const struct net_device *net_dev);
extern struct rtnl_link_ops batadv_link_ops;
int batadv_softif_create_vlan(struct batadv_priv *bat_priv, unsigned short vid);
void batadv_softif_vlan_put(struct batadv_softif_vlan *softif_vlan);