diff options
| author |   Sven Eckelmann <sven@narfation.org> | 2016-07-15 17:39:33 +0200 |
|---|---|---|
| committer |   Simon Wunderlich <sw@simonwunderlich.de> | 2016-08-09 07:54:53 +0200 |
| commit | 27d684ec5bc7caf8a72a7a0383fa3e1631ee2b25 (patch) | |
| tree | f06c4c9e9dc62a0b27e5739cd956cbb65bcaf78c /net/batman-adv | |
| parent | batman-adv: Place kref_get for tvlv_container near use (diff) | |
| download | linux-dev-27d684ec5bc7caf8a72a7a0383fa3e1631ee2b25.tar.xz linux-dev-27d684ec5bc7caf8a72a7a0383fa3e1631ee2b25.zip | |
batman-adv: Place kref_get for tvlv_handler near use
It is hard to understand why the refcnt is increased when it isn't done
near the actual place the new reference is used. So using kref_get right
before the place which requires the reference and in the same function
helps to avoid accidental problems caused by incorrect reference counting.
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Diffstat (limited to 'net/batman-adv')
| -rw-r--r-- | net/batman-adv/tvlv.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/net/batman-adv/tvlv.c b/net/batman-adv/tvlv.c index 353386780e6d..77654f055f24 100644 --- a/net/batman-adv/tvlv.c +++ b/net/batman-adv/tvlv.c @@ -547,8 +547,12 @@ void batadv_tvlv_handler_register(struct batadv_priv *bat_priv, INIT_HLIST_NODE(&tvlv_handler->list); spin_lock_bh(&bat_priv->tvlv.handler_list_lock); + kref_get(&tvlv_handler->refcount); hlist_add_head_rcu(&tvlv_handler->list, &bat_priv->tvlv.handler_list); spin_unlock_bh(&bat_priv->tvlv.handler_list_lock); + + /* don't return reference to new tvlv_handler */ + batadv_tvlv_handler_put(tvlv_handler); } /** |