diff options
| author |   Michael Chan <mchan@broadcom.com> | 2006-06-17 21:58:45 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2006-06-17 21:58:45 -0700 |
| commit | 00b7050426da8e7e58c889c5c80a19920d2d41b3 (patch) | |
| tree | 55a07464fdf81b23fced966feca2b041af77c6f6 /net/bridge/br_if.c | |
| parent | [TG3]: Remove unnecessary tx_lock (diff) | |
| download | linux-dev-00b7050426da8e7e58c889c5c80a19920d2d41b3.tar.xz linux-dev-00b7050426da8e7e58c889c5c80a19920d2d41b3.zip | |
[TG3]: Convert to non-LLTX
Herbert Xu pointed out that it is unsafe to call netif_tx_disable()
from LLTX drivers because it uses dev->xmit_lock to synchronize
whereas LLTX drivers use private locks.
Convert tg3 to non-LLTX to fix this issue. tg3 is a lockless driver
where hard_start_xmit and tx completion handling can run concurrently
under normal conditions. A tx_lock is only needed to prevent
netif_stop_queue and netif_wake_queue race condtions when the queue
is full.
So whether we use LLTX or non-LLTX, it makes practically no
difference.
Signed-off-by: Michael Chan <mchan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge/br_if.c')
0 files changed, 0 insertions, 0 deletions