diff options
| author |   Pavel Emelyanov <xemul@openvz.org> | 2007-11-29 23:58:58 +1100 |
|---|---|---|
| committer |   Herbert Xu <herbert@gondor.apana.org.au> | 2007-11-29 23:58:58 +1100 |
| commit | 82de382ce8e1c7645984616728dc7aaa057821e4 (patch) | |
| tree | 980ce308c87e8aa9bbf8381251b805d7d6a108c4 /net/bridge/netfilter | |
| parent | [BRIDGE]: Lost call to br_fdb_fini() in br_init() error path (diff) | |
| download | linux-dev-82de382ce8e1c7645984616728dc7aaa057821e4.tar.xz linux-dev-82de382ce8e1c7645984616728dc7aaa057821e4.zip | |
[BRIDGE]: Properly dereference the br_should_route_hook
This hook is protected with the RCU, so simple
if (br_should_route_hook)
br_should_route_hook(...)
is not enough on some architectures.
Use the rcu_dereference/rcu_assign_pointer in this case.
Fixed Stephen's comment concerning using the typeof().
Signed-off-by: Pavel Emelyanov <xemul@openvz.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Diffstat (limited to 'net/bridge/netfilter')
| -rw-r--r-- | net/bridge/netfilter/ebtable_broute.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/net/bridge/netfilter/ebtable_broute.c b/net/bridge/netfilter/ebtable_broute.c index e44519ebf1d2..be6f18681053 100644 --- a/net/bridge/netfilter/ebtable_broute.c +++ b/net/bridge/netfilter/ebtable_broute.c @@ -70,13 +70,13 @@ static int __init ebtable_broute_init(void) if (ret < 0) return ret; /* see br_input.c */ - br_should_route_hook = ebt_broute; + rcu_assign_pointer(br_should_route_hook, ebt_broute); return ret; } static void __exit ebtable_broute_fini(void) { - br_should_route_hook = NULL; + rcu_assign_pointer(br_should_route_hook, NULL); synchronize_net(); ebt_unregister_table(&broute_table); } |