diff options
| author |   Edwin Peer <edwin.peer@broadcom.com> | 2021-02-05 17:37:32 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-02-08 16:18:58 -0800 |
| commit | 3aa6bce9af0e25b735c9c1263739a5639a336ae8 (patch) | |
| tree | 044f908132ba3671debf843068c8f9c23728d464 /net/bridge | |
| parent | vsock/virtio: update credit only if socket is not closed (diff) | |
| download | linux-dev-3aa6bce9af0e25b735c9c1263739a5639a336ae8.tar.xz linux-dev-3aa6bce9af0e25b735c9c1263739a5639a336ae8.zip | |
net: watchdog: hold device global xmit lock during tx disable
Prevent netif_tx_disable() running concurrently with dev_watchdog() by
taking the device global xmit lock. Otherwise, the recommended:
netif_carrier_off(dev);
netif_tx_disable(dev);
driver shutdown sequence can happen after the watchdog has already
checked carrier, resulting in possible false alarms. This is because
netif_tx_lock() only sets the frozen bit without maintaining the locks
on the individual queues.
Fixes: c3f26a269c24 ("netdev: Fix lockdep warnings in multiqueue configurations.")
Signed-off-by: Edwin Peer <edwin.peer@broadcom.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/bridge')
0 files changed, 0 insertions, 0 deletions