diff options
| author |   Dan Carpenter <dan.carpenter@oracle.com> | 2015-02-19 12:13:13 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-02-20 17:35:14 -0500 |
| commit | 278f7b4fffce9ad267406cf8800df271d14f4a16 (patch) | |
| tree | 7998890a3cedcf7dab3edab58064306734d3707c /net/caif/cffrml.c | |
| parent | cxgb4: Fix incorrect 'c' suffix to %pI4, use %pISc instead (diff) | |
| download | linux-dev-278f7b4fffce9ad267406cf8800df271d14f4a16.tar.xz linux-dev-278f7b4fffce9ad267406cf8800df271d14f4a16.zip | |
caif: fix a signedness bug in cfpkt_iterate()
The cfpkt_iterate() function can return -EPROTO on error, but the
function is a u16 so the negative value gets truncated to a positive
unsigned short. This causes a static checker warning.
The only caller which might care is cffrml_receive(), when it's checking
the frame checksum. I modified cffrml_receive() so that it never says
-EPROTO is a valid checksum.
Also this isn't ever going to be inlined so I removed the "inline".
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/caif/cffrml.c')
| -rw-r--r-- | net/caif/cffrml.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/caif/cffrml.c b/net/caif/cffrml.c index 8bc7caa28e64..434ba8557826 100644 --- a/net/caif/cffrml.c +++ b/net/caif/cffrml.c @@ -84,7 +84,7 @@ static int cffrml_receive(struct cflayer *layr, struct cfpkt *pkt) u16 tmp; u16 len; u16 hdrchks; - u16 pktchks; + int pktchks; struct cffrml *this; this = container_obj(layr); |