diff options
| author |   Pavel Skripkin <paskripkin@gmail.com> | 2021-06-03 19:39:11 +0300 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-06-03 15:05:07 -0700 |
| commit | b53558a950a89824938e9811eddfc8efcd94e1bb (patch) | |
| tree | cffe51ae8ead138fa2648c1eef0166674d38f7fb /net/caif | |
| parent | net: caif: add proper error handling (diff) | |
| download | linux-dev-b53558a950a89824938e9811eddfc8efcd94e1bb.tar.xz linux-dev-b53558a950a89824938e9811eddfc8efcd94e1bb.zip | |
net: caif: fix memory leak in caif_device_notify
In case of caif_enroll_dev() fail, allocated
link_support won't be assigned to the corresponding
structure. So simply free allocated pointer in case
of error
Fixes: 7c18d2205ea7 ("caif: Restructure how link caif link layer enroll")
Cc: stable@vger.kernel.org
Reported-and-tested-by: syzbot+7ec324747ce876a29db6@syzkaller.appspotmail.com
Signed-off-by: Pavel Skripkin <paskripkin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/caif')
| -rw-r--r-- | net/caif/caif_dev.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/net/caif/caif_dev.c b/net/caif/caif_dev.c index fffbe41440b3..440139706130 100644 --- a/net/caif/caif_dev.c +++ b/net/caif/caif_dev.c @@ -370,6 +370,7 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, struct cflayer *layer, *link_support; int head_room = 0; struct caif_device_entry_list *caifdevs; + int res; cfg = get_cfcnfg(dev_net(dev)); caifdevs = caif_device_list(dev_net(dev)); @@ -395,8 +396,10 @@ static int caif_device_notify(struct notifier_block *me, unsigned long what, break; } } - caif_enroll_dev(dev, caifdev, link_support, head_room, + res = caif_enroll_dev(dev, caifdev, link_support, head_room, &layer, NULL); + if (res) + cfserl_release(link_support); caifdev->flowctrl = dev_flowctrl; break; |