diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-08-26 09:19:15 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-08-27 20:57:43 -0700 |
| commit | fdfc5c8594c24c5df883583ebd286321a80e0a67 (patch) | |
| tree | ec29c0b7fcdb6539c7df8a05dcce84ecded0fba3 /net/ceph | |
| parent | net/rds: Fix info leak in rds6_inc_info_copy() (diff) | |
| download | linux-dev-fdfc5c8594c24c5df883583ebd286321a80e0a67.tar.xz linux-dev-fdfc5c8594c24c5df883583ebd286321a80e0a67.zip | |
tcp: remove empty skb from write queue in error cases
Vladimir Rutsky reported stuck TCP sessions after memory pressure
events. Edge Trigger epoll() user would never receive an EPOLLOUT
notification allowing them to retry a sendmsg().
Jason tested the case of sk_stream_alloc_skb() returning NULL,
but there are other paths that could lead both sendmsg() and sendpage()
to return -1 (EAGAIN), with an empty skb queued on the write queue.
This patch makes sure we remove this empty skb so that
Jason code can detect that the queue is empty, and
call sk->sk_write_space(sk) accordingly.
Fixes: ce5ec440994b ("tcp: ensure epoll edge trigger wakeup when write queue is empty")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Jason Baron <jbaron@akamai.com>
Reported-by: Vladimir Rutsky <rutsky@google.com>
Cc: Soheil Hassas Yeganeh <soheil@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/ceph')
0 files changed, 0 insertions, 0 deletions