diff options
| author |   Eric Dumazet <edumazet@google.com> | 2015-11-18 06:31:02 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-11-18 16:17:42 -0500 |
| commit | 34cbe27e811c591c854a39c0dee1b461bb796953 (patch) | |
| tree | f9371f25907985feef0b5e9c9d8b0f7ba1eb2432 /net/core/dev.c | |
| parent | net: move napi_hash[] into read mostly section (diff) | |
| download | linux-dev-34cbe27e811c591c854a39c0dee1b461bb796953.tar.xz linux-dev-34cbe27e811c591c854a39c0dee1b461bb796953.zip | |
net: napi_hash_del() returns a boolean status
napi_hash_del() will soon be used from both drivers (if they want)
or core networking stack.
Callers are responsibles to ensure an RCU grace period is respected
before freeing napi structure : napi_hash_del() can signal if
this RCU grace period is needed or not.
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
| -rw-r--r-- | net/core/dev.c | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/net/core/dev.c b/net/core/dev.c index 02dfbd91a8e4..59dddac1c2e7 100644 --- a/net/core/dev.c +++ b/net/core/dev.c @@ -4760,14 +4760,18 @@ EXPORT_SYMBOL_GPL(napi_hash_add); /* Warning : caller is responsible to make sure rcu grace period * is respected before freeing memory containing @napi */ -void napi_hash_del(struct napi_struct *napi) +bool napi_hash_del(struct napi_struct *napi) { + bool rcu_sync_needed = false; + spin_lock(&napi_hash_lock); - if (test_and_clear_bit(NAPI_STATE_HASHED, &napi->state)) + if (test_and_clear_bit(NAPI_STATE_HASHED, &napi->state)) { + rcu_sync_needed = true; hlist_del_rcu(&napi->napi_hash_node); - + } spin_unlock(&napi_hash_lock); + return rcu_sync_needed; } EXPORT_SYMBOL_GPL(napi_hash_del); |