diff options
| author |   Eric Dumazet <edumazet@google.com> | 2012-12-10 12:32:03 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2012-12-11 12:49:53 -0500 |
| commit | f8e8f97c11d5ff3cc47d85b97c7c35e443dcf490 (patch) | |
| tree | dc56e7e2030cfd0fd0e8b876f86d18a08514a38c /net/core/dev.c | |
| parent | bnx2x: use netdev_alloc_frag() (diff) | |
| download | linux-dev-f8e8f97c11d5ff3cc47d85b97c7c35e443dcf490.tar.xz linux-dev-f8e8f97c11d5ff3cc47d85b97c7c35e443dcf490.zip | |
net: fix a race in gro_cell_poll()
Dmitry Kravkov reported packet drops for GRE packets since GRO support
was added.
There is a race in gro_cell_poll() because we call napi_complete()
without any synchronization with a concurrent gro_cells_receive()
Once bug was triggered, we queued packets but did not schedule NAPI
poll.
We can fix this issue using the spinlock protected the napi_skbs queue,
as we have to hold it to perform skb dequeue anyway.
As we open-code skb_dequeue(), we no longer need to mask IRQS, as both
producer and consumer run under BH context.
Bug added in commit c9e6bc644e (net: add gro_cells infrastructure)
Reported-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Dmitry Kravkov <dmitry@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/dev.c')
0 files changed, 0 insertions, 0 deletions