diff options
| author |   Ammar Faizi <ammarfaizi2@gnuweeb.org> | 2022-08-01 18:59:56 +0700 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2022-08-01 12:47:10 -0700 |
| commit | 80ef928643c1558a0474389fcd680a5ccd6c86e6 (patch) | |
| tree | 0878d6785164668d3a5db1fa05d1aa0efed505f9 /net/core/devlink.c | |
| parent | net/tls: Remove redundant workqueue flush before destroy (diff) | |
| download | linux-dev-80ef928643c1558a0474389fcd680a5ccd6c86e6.tar.xz linux-dev-80ef928643c1558a0474389fcd680a5ccd6c86e6.zip | |
net: devlink: Fix missing mutex_unlock() call
Commit 2dec18ad826f forgets to call mutex_unlock() before the function
returns in the error path:
New smatch warnings:
net/core/devlink.c:6392 devlink_nl_cmd_region_new() warn: inconsistent \
returns '®ion->snapshot_lock'.
Make sure we call mutex_unlock() in this error path.
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Fixes: 2dec18ad826f ("net: devlink: remove region snapshots list dependency on devlink->lock")
Signed-off-by: Ammar Faizi <ammarfaizi2@gnuweeb.org>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Link: https://lore.kernel.org/r/20220801115742.1309329-1-ammar.faizi@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/core/devlink.c')
| -rw-r--r-- | net/core/devlink.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/net/core/devlink.c b/net/core/devlink.c index 889e7e3d3e8a..5da5c7cca98a 100644 --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -6315,8 +6315,10 @@ devlink_nl_cmd_region_new(struct sk_buff *skb, struct genl_info *info) snapshot = devlink_region_snapshot_get_by_id(region, snapshot_id); - if (WARN_ON(!snapshot)) - return -EINVAL; + if (WARN_ON(!snapshot)) { + err = -EINVAL; + goto unlock; + } msg = devlink_nl_region_notify_build(region, snapshot, DEVLINK_CMD_REGION_NEW, |