diff options
| author |   Alexander Lobakin <alobakin@pm.me> | 2021-03-12 20:08:57 +0000 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2021-03-14 14:30:20 -0700 |
| commit | a25f822285420486f5da434efc8d940d42a83bce (patch) | |
| tree | c519628bcb0154d5af1f28d3641c0495c8f59d92 /net/core/flow_dissector.c | |
| parent | net: qrtr: fix a kernel-infoleak in qrtr_recvmsg() (diff) | |
| download | linux-dev-a25f822285420486f5da434efc8d940d42a83bce.tar.xz linux-dev-a25f822285420486f5da434efc8d940d42a83bce.zip | |
flow_dissector: fix byteorder of dissected ICMP ID
flow_dissector_key_icmp::id is of type u16 (CPU byteorder),
ICMP header has its ID field in network byteorder obviously.
Sparse says:
net/core/flow_dissector.c:178:43: warning: restricted __be16 degrades to integer
Convert ID value to CPU byteorder when storing it into
flow_dissector_key_icmp.
Fixes: 5dec597e5cd0 ("flow_dissector: extract more ICMP information")
Signed-off-by: Alexander Lobakin <alobakin@pm.me>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/flow_dissector.c')
| -rw-r--r-- | net/core/flow_dissector.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/flow_dissector.c b/net/core/flow_dissector.c index 2ef2224b3bff..a96a4f5de0ce 100644 --- a/net/core/flow_dissector.c +++ b/net/core/flow_dissector.c @@ -176,7 +176,7 @@ void skb_flow_get_icmp_tci(const struct sk_buff *skb, * avoid confusion with packets without such field */ if (icmp_has_id(ih->type)) - key_icmp->id = ih->un.echo.id ? : 1; + key_icmp->id = ih->un.echo.id ? ntohs(ih->un.echo.id) : 1; else key_icmp->id = 0; } |