diff options
| author |   Tom Herbert <tom@herbertland.com> | 2015-09-01 18:11:04 -0700 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2015-09-01 20:20:02 -0700 |
| commit | de4c1f8ba302ccf4f2b3b17dc614b0a0b14d351a (patch) | |
| tree | b8fb3ed074d6752702b7e31628cf19c454aab164 /net/core/flow_dissector.c | |
| parent | Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/jkirsher/next-queue (diff) | |
| download | linux-dev-de4c1f8ba302ccf4f2b3b17dc614b0a0b14d351a.tar.xz linux-dev-de4c1f8ba302ccf4f2b3b17dc614b0a0b14d351a.zip | |
flow_dissector: Fix function argument ordering dependency
Commit c6cc1ca7f4d70c ("flowi: Abstract out functions to get flow hash
based on flowi") introduced a bug in __skb_set_sw_hash where we
require a dependency on evaluating arguments in a function in order.
There is no such ordering enforced in C, so this incorrect. This
patch fixes that by splitting out the arguments. This bug was
found via a compiler warning that keys may be uninitialized.
Signed-off-by: Tom Herbert <tom@herbertland.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/flow_dissector.c')
0 files changed, 0 insertions, 0 deletions