diff options
| author |   Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp> | 2018-06-01 17:16:58 +0900 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-06-01 10:39:24 -0400 |
| commit | af066ed3d45551e703d95d7e6c67d36a63809bc2 (patch) | |
| tree | 9b3e15ec82a6f5ad51dfdb06a6291a2e1af96a04 /net/core/rtnetlink.c | |
| parent | virtio_net: fix error return code in virtnet_probe() (diff) | |
| download | linux-dev-af066ed3d45551e703d95d7e6c67d36a63809bc2.tar.xz linux-dev-af066ed3d45551e703d95d7e6c67d36a63809bc2.zip | |
rtnetlink: Fix null-ptr-deref in rtnl_newlink
In rtnl_newlink(), NULL check is performed on m_ops however member of
ops is accessed. Fixed by accessing member of m_ops instead of ops.
[ 345.432629] BUG: KASAN: null-ptr-deref in rtnl_newlink+0x400/0x1110
[ 345.432629] Read of size 4 at addr 0000000000000088 by task ip/986
[ 345.432629]
[ 345.432629] CPU: 1 PID: 986 Comm: ip Not tainted 4.17.0-rc6+ #9
[ 345.432629] Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS 1.10.2-1ubuntu1 04/01/2014
[ 345.432629] Call Trace:
[ 345.432629] dump_stack+0xc6/0x150
[ 345.432629] ? dump_stack_print_info.cold.0+0x1b/0x1b
[ 345.432629] ? kasan_report+0xb4/0x410
[ 345.432629] kasan_report.cold.4+0x8f/0x91
[ 345.432629] ? rtnl_newlink+0x400/0x1110
[ 345.432629] rtnl_newlink+0x400/0x1110
[...]
Fixes: ccf8dbcd062a ("rtnetlink: Remove VLA usage")
Signed-off-by: Prashant Bhole <bhole_prashant_q7@lab.ntt.co.jp>
Tested-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/rtnetlink.c')
| -rw-r--r-- | net/core/rtnetlink.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/net/core/rtnetlink.c b/net/core/rtnetlink.c index 8ca49a0e13fb..9a1ba2015ad8 100644 --- a/net/core/rtnetlink.c +++ b/net/core/rtnetlink.c @@ -2936,7 +2936,7 @@ replay: } if (m_ops) { - if (ops->slave_maxtype > RTNL_SLAVE_MAX_TYPE) + if (m_ops->slave_maxtype > RTNL_SLAVE_MAX_TYPE) return -EINVAL; if (m_ops->slave_maxtype && |