diff options
| author |   Heiner Kallweit <hkallweit1@gmail.com> | 2018-07-01 00:25:19 +0200 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2018-07-02 22:40:31 +0900 |
| commit | 335c997dce5c448ee06b3fd4dfe49fc7279f73ce (patch) | |
| tree | 094a2306bd6d8bf952bb510ee12366cf975fc1ef /net/core/sock.c | |
| parent | netdevsim: fix sa_idx out of bounds check (diff) | |
| download | linux-dev-335c997dce5c448ee06b3fd4dfe49fc7279f73ce.tar.xz linux-dev-335c997dce5c448ee06b3fd4dfe49fc7279f73ce.zip | |
r8169: remove old PHY reset hack
This hack (affecting the non-PCIe models only) was introduced in 2004
to deal with link negotiation failures in 1GBit mode. Based on a
comment in the r8169 vendor driver I assume the issue affects RTL8169sb
in combination with particular 1GBit switch models.
Resetting the PHY every 10s and hoping that one fine day we will make
it to establish the link seems to be very hacky to me. I'd say:
If 1GBit doesn't work reliably in a users environment then the user
should remove 1GBit from the advertised modes, e.g. by using
ethtool -s <if> advertise <10/100 modes>
If the issue affects one chip version only and that with most link
partners, then we could also think of removing 1GBit from the
advertised modes for this chip version in the driver.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core/sock.c')
0 files changed, 0 insertions, 0 deletions