diff options
| author |   Menglong Dong <imagedong@tencent.com> | 2022-05-13 11:03:37 +0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2022-05-16 10:47:43 +0100 |
| commit | 20bbcd0a94c6686c2692e6f7081163c233d7ce40 (patch) | |
| tree | b86d8d7397c28d81f75992c97872be842ee3a092 /net/core | |
| parent | net: dm: check the boundary of skb drop reasons (diff) | |
| download | linux-dev-20bbcd0a94c6686c2692e6f7081163c233d7ce40.tar.xz linux-dev-20bbcd0a94c6686c2692e6f7081163c233d7ce40.zip | |
net: skb: check the boundrary of drop reason in kfree_skb_reason()
Sometimes, we may forget to reset skb drop reason to NOT_SPECIFIED after
we make it the return value of the functions with return type of enum
skb_drop_reason, such as tcp_inbound_md5_hash. Therefore, its value can
be SKB_NOT_DROPPED_YET(0), which is invalid for kfree_skb_reason().
So we check the range of drop reason in kfree_skb_reason() with
DEBUG_NET_WARN_ON_ONCE().
Reviewed-by: Jiang Biao <benbjiang@tencent.com>
Reviewed-by: Hao Peng <flyingpeng@tencent.com>
Signed-off-by: Menglong Dong <imagedong@tencent.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/skbuff.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/net/core/skbuff.c b/net/core/skbuff.c index bd16e158b366..2fea964f09d8 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -771,6 +771,8 @@ void kfree_skb_reason(struct sk_buff *skb, enum skb_drop_reason reason) if (!skb_unref(skb)) return; + DEBUG_NET_WARN_ON_ONCE(reason <= 0 || reason >= SKB_DROP_REASON_MAX); + trace_kfree_skb(skb, __builtin_return_address(0), reason); __kfree_skb(skb); } |