diff options
| author |   Eric Dumazet <edumazet@google.com> | 2019-12-07 12:23:21 -0800 |
|---|---|---|
| committer |   David S. Miller <davem@davemloft.net> | 2019-12-09 09:48:47 -0800 |
| commit | f394722fb0d0f701119368959d7cd0ecbc46363a (patch) | |
| tree | d3838cf1766c2faf7a89520aed6c8e59ee8c0bed /net/core | |
| parent | Merge tag 'linux-can-fixes-for-5.5-20191208' of git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can (diff) | |
| download | linux-dev-f394722fb0d0f701119368959d7cd0ecbc46363a.tar.xz linux-dev-f394722fb0d0f701119368959d7cd0ecbc46363a.zip | |
neighbour: remove neigh_cleanup() method
neigh_cleanup() has not been used for seven years, and was a wrong design.
Messing with shared pointer in bond_neigh_init() without proper
memory barriers would at least trigger syzbot complains eventually.
It is time to remove this stuff.
Fixes: b63b70d87741 ("IPoIB: Use a private hash table for path lookup in xmit path")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'net/core')
| -rw-r--r-- | net/core/neighbour.c | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/net/core/neighbour.c b/net/core/neighbour.c index 652da6369037..920784a9b7ff 100644 --- a/net/core/neighbour.c +++ b/net/core/neighbour.c @@ -98,9 +98,6 @@ static int neigh_blackhole(struct neighbour *neigh, struct sk_buff *skb) static void neigh_cleanup_and_release(struct neighbour *neigh) { - if (neigh->parms->neigh_cleanup) - neigh->parms->neigh_cleanup(neigh); - trace_neigh_cleanup_and_release(neigh, 0); __neigh_notify(neigh, RTM_DELNEIGH, 0, 0); call_netevent_notifiers(NETEVENT_NEIGH_UPDATE, neigh); |