diff options
| author |   Gerrit Renker <gerrit@erg.abdn.ac.uk> | 2006-12-10 00:03:51 -0200 |
|---|---|---|
| committer |   David S. Miller <davem@sunset.davemloft.net> | 2006-12-11 14:34:45 -0800 |
| commit | 0f9e5b573f7249b0e04a03457b55081d1f60f2bf (patch) | |
| tree | fa33e3252d5df520348bb22d2a14aeac0e6b2bfc /net/dccp/ccids/ccid3.h | |
| parent | [DCCP] ccid3: Simplify calculation for reverse lookup of p (diff) | |
| download | linux-dev-0f9e5b573f7249b0e04a03457b55081d1f60f2bf.tar.xz linux-dev-0f9e5b573f7249b0e04a03457b55081d1f60f2bf.zip | |
[DCCP]: Debug timeval operations
Problem:
Most target types in the CCID3 code are u32, so subtle conversion errors
can occur if signed time calculations yield negative results: the original
values are lost in the conversion to unsigned, calculation errors go undetected.
This patch therefore
* sets all critical time types from unsigned to suseconds_t
* avoids comparison between signed/unsigned via type-casting
* provides ample warning messages in case time calculations are negative
These warning messages can be removed at a later stage when the code
has undergone more testing.
Signed-off-by: Gerrit Renker <gerrit@erg.abdn.ac.uk>
Acked-by: Ian McDonald <ian.mcdonald@jandi.co.nz>
Signed-off-by: Arnaldo Carvalho de Melo <acme@mandriva.com>
Diffstat (limited to 'net/dccp/ccids/ccid3.h')
0 files changed, 0 insertions, 0 deletions