diff options
| author |   Kuniyuki Iwashima <kuniyu@amazon.co.jp> | 2021-11-22 19:16:22 +0900 |
|---|---|---|
| committer |   Jakub Kicinski <kuba@kernel.org> | 2021-11-23 20:16:22 -0800 |
| commit | b4a8e7493d74121093f2e1e024a9d3bb1a912912 (patch) | |
| tree | cad53fd48718c24cb5d321fb918dbe9d1f71d719 /net/dccp/proto.c | |
| parent | dccp/tcp: Remove an unused argument in inet_csk_listen_start(). (diff) | |
| download | linux-dev-b4a8e7493d74121093f2e1e024a9d3bb1a912912.tar.xz linux-dev-b4a8e7493d74121093f2e1e024a9d3bb1a912912.zip | |
dccp: Inline dccp_listen_start().
This patch inlines dccp_listen_start() and removes a stale comment in
inet_dccp_listen() so that it looks like inet_listen().
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.co.jp>
Reviewed-by: Richard Sailer <richard_siegfried@systemli.org>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'net/dccp/proto.c')
| -rw-r--r-- | net/dccp/proto.c | 27 |
1 files changed, 11 insertions, 16 deletions
diff --git a/net/dccp/proto.c b/net/dccp/proto.c index 55b8f958cdd2..a976b4d29892 100644 --- a/net/dccp/proto.c +++ b/net/dccp/proto.c @@ -238,17 +238,6 @@ void dccp_destroy_sock(struct sock *sk) EXPORT_SYMBOL_GPL(dccp_destroy_sock); -static inline int dccp_listen_start(struct sock *sk) -{ - struct dccp_sock *dp = dccp_sk(sk); - - dp->dccps_role = DCCP_ROLE_LISTEN; - /* do not start to listen if feature negotiation setup fails */ - if (dccp_feat_finalise_settings(dp)) - return -EPROTO; - return inet_csk_listen_start(sk); -} - static inline int dccp_need_reset(int state) { return state != DCCP_CLOSED && state != DCCP_LISTEN && @@ -931,11 +920,17 @@ int inet_dccp_listen(struct socket *sock, int backlog) * we can only allow the backlog to be adjusted. */ if (old_state != DCCP_LISTEN) { - /* - * FIXME: here it probably should be sk->sk_prot->listen_start - * see tcp_listen_start - */ - err = dccp_listen_start(sk); + struct dccp_sock *dp = dccp_sk(sk); + + dp->dccps_role = DCCP_ROLE_LISTEN; + + /* do not start to listen if feature negotiation setup fails */ + if (dccp_feat_finalise_settings(dp)) { + err = -EPROTO; + goto out; + } + + err = inet_csk_listen_start(sk); if (err) goto out; } |